Hello, we apologize but forum registrations are non-functional at this time. This issue should be fixed around mid-December. Until then, please stop by our Discord channel if you'd like to get in touch with the team. Thanks!

Subversion Commit Log

For discussion of the code running behind the game

Moderator: Staff

Locked
User avatar
prophile
Senior Member
Posts: 324
Joined: Fri Jan 27, 2006 12:18 pm
Location: Chaldon, Surrey, UK
Contact:

Re: Subversion Commit Log

Post by prophile » Mon Feb 01, 2010 11:49 pm

Committed revision #1685.
============================================================
Files Modified
M src/engine/video/video.h
M src/engine/video/video.cpp
M src/engine/input.cpp
M src/common/gui/gui.h
M src/common/gui/gui.cpp

Primary Changes
  • Moved FPS display from the GUI component to the video component
Miscellaneous
Whilst I can't check it myself, this should probably fix the breakage in the editor.
Alastair Lynn / Resident Whinger / Allacrost
User avatar
Roots
Dictator
Posts: 8669
Joined: Wed Jun 16, 2004 12:07 pm
Location: Austin TX
Contact:

Re: Subversion Commit Log

Post by Roots » Tue Feb 02, 2010 12:11 am

prophile wrote: Miscellaneous
Whilst I can't check it myself, this should probably fix the breakage in the editor.
It did, editor is now fixed. :approve:


By the way I forgot to say this, but a HUGE thanks for separating the GUI from the video engine. I am really glad that that is finished. :bow: :bow: :bow:
Image
User avatar
prophile
Senior Member
Posts: 324
Joined: Fri Jan 27, 2006 12:18 pm
Location: Chaldon, Surrey, UK
Contact:

Re: Subversion Commit Log

Post by prophile » Tue Feb 02, 2010 4:54 am

You're welcome :)
Alastair Lynn / Resident Whinger / Allacrost
User avatar
Shmoopy909
Newbie
Posts: 14
Joined: Mon Jun 01, 2009 9:31 am

Re: Subversion Commit Log

Post by Shmoopy909 » Tue Feb 02, 2010 7:15 pm

Committed revision #1688.
============================================================
Files Modified
M src/modes/boot/boot.h
M src/modes/boot/boot.cpp
M txt/allacrost.pot
M txt/POTFILES.in
M txt/fr.po
A dat/config/languages.lua

Primary Changes

* Added in language support for the main menu
* Added in a new file dat/config/languages.lua that holds all the language information
* Updated allacrost.pot and POTFILES.in to account for the new language support

Miscellaneous
Adding a new language into the main menu is easy. Just open up dat/config/languages.lua and add in the two letter language code and the language in english to the languages vector. When you run the game it will update the menu with the new languages as well as set the SystemLanguage to the language code given by languages.lua

EDIT:
I think we need to start cleaning up boot.cpp and restructuring the logic, it is getting painful to look at.
User avatar
Roots
Dictator
Posts: 8669
Joined: Wed Jun 16, 2004 12:07 pm
Location: Austin TX
Contact:

Re: Subversion Commit Log

Post by Roots » Tue Feb 02, 2010 9:15 pm

Committed revision #1689.
============================================================
Files Modified
M src/global/global_effects.cpp
M src/global/global.cpp
M src/global/global_actors.h
M src/global/global.h
M src/main.cpp
M dat/global.lua

Primary Changes
  • Cleaned up global.h and global.cpp, mostly comments and debug messages. Also fixed a few warnings that were being printed
  • SingletonInitialize() was not being called on new GUIManager class so I added a call to it
  • In main.cpp the ExitAllacrost() clean-up function call-back was commented out leading to a lot of class destructors not being called. :nono: Added it back in.
Miscellaneous
There's a crash bug related to scroll arrows in the GUIManager class not loading properly or something like that. rujasu and I are online and looking into a fix. At this point any mode that uses scroll arrows will crash (shop mode, menu mode, battle mode from the boot menu all crash, but work in game as far as I can tell)
Image
rujasu
Developer
Posts: 758
Joined: Sat Feb 24, 2007 10:40 pm
Location: Maryland, USA

Re: Subversion Commit Log

Post by rujasu » Tue Feb 02, 2010 10:04 pm

Committed revision #1690.
============================================================
/trunk/demo/src/ (main.cpp modes/boot/boot.cpp): Fixed debug mode crashes.
User avatar
prophile
Senior Member
Posts: 324
Joined: Fri Jan 27, 2006 12:18 pm
Location: Chaldon, Surrey, UK
Contact:

Re: Subversion Commit Log

Post by prophile » Tue Feb 02, 2010 11:57 pm

Committed revision #1692.
============================================================
Files Modified
M src/modes/map/map_dialogue.cpp

Primary Changes
  • Disabled cancelling dialogues.
Miscellaneous
This fixes the issue where one could get stuck in the opening map.
Alastair Lynn / Resident Whinger / Allacrost
User avatar
Roots
Dictator
Posts: 8669
Joined: Wed Jun 16, 2004 12:07 pm
Location: Austin TX
Contact:

Re: Subversion Commit Log

Post by Roots » Wed Feb 03, 2010 3:55 pm

Committed revision #1695.
============================================================
Files Modified
M src/global/global.cpp
M src/global/global_actors.h
M src/global/global.h
M src/global/global_actors.cpp
M src/modes/shop/shop.cpp
M src/modes/battle/battle_windows.cpp
M src/modes/battle/battle_actors.cpp
M src/modes/battle/battle.cpp

Primary Changes
  • Cleaned up global_actors.h and global_actors.cpp. Also improved the code structure and flow here to make it more reliable, safe, and readable code
Miscellaneous
I didn't fully finish the changes I wanted to the GlobalCharacterGrowth and GlobalCharacter classes. I was having a difficult time understanding how growth worked (even with the existing comments). I was getting bogged down on it so I decided to just commit what I had and come back to it later. I think that bugs in GlobalCharacterGrowth are responsible for things like new skills being learned in the battle victory window that the characters already know. I'll find and fix that bug regardless of whether its in the global code or battle code.

My two issues the GlobalCharacter class were the way it co-functions with GlobalCharacterGrowth and the messy conglomeration of temporary containers and accessor methods for storing/retrieving related character images. To address this will take a little more forethought and I wanted to get feedback from the team before moving in a definite direction on these changes.
Image
User avatar
Roots
Dictator
Posts: 8669
Joined: Wed Jun 16, 2004 12:07 pm
Location: Austin TX
Contact:

Re: Subversion Commit Log

Post by Roots » Wed Feb 03, 2010 6:38 pm

Committed revision #1696.
============================================================
Files Modified
M src/global/global_objects.h
M src/global/global_actors.h
M src/global/global.h
M src/global/global_objects.cpp
M src/global/global_actors.cpp
M src/modes/battle/battle_events.cpp

Primary Changes
  • Cleaned up global_object.h and global_objects.cpp completely. Like always, I improved code structure, flow, re-use, comments, debug print statements, everything. Its a lot better now even though it still works more or less the same.
Image
User avatar
Roots
Dictator
Posts: 8669
Joined: Wed Jun 16, 2004 12:07 pm
Location: Austin TX
Contact:

Re: Subversion Commit Log

Post by Roots » Wed Feb 03, 2010 7:54 pm

Committed revision #1697.
============================================================
Files Modified
M src/global/global_objects.h
M src/global/global_skills.cpp
M src/global/global.h
M src/global/global_skills.h
M src/global/global_objects.cpp
M src/global/global_actors.cpp

Primary Changes
  • Cleaned up global_skills.h and global_skills.cpp completely
Miscellaneous
I've also been eliminating the need for virtually every global class to be declared a friend of GameGlobal because those classes need to access one or two members. The cooperation between the global classes is much nicer now. :)
Image
User avatar
Roots
Dictator
Posts: 8669
Joined: Wed Jun 16, 2004 12:07 pm
Location: Austin TX
Contact:

Re: Subversion Commit Log

Post by Roots » Thu Feb 04, 2010 2:58 pm

Committed revision #1698.
============================================================
Files Modified
M src/global/global_effects.cpp
M src/global/global_skills.cpp
M src/global/global_effects.h
M src/global/global.h
M src/modes/battle/battle_actors.cpp

Primary Changes
  • Cleaned up global_effects.h and global_effects.cpp. I think the GlobalStatusEffect still needs some big changes, but I left it in its current state until those changes are ready to be made
Miscellaneous
My global code clean up work is now finished. There are some loose ends though that I didn't get to.

1) The GlobalCharacterGrowth class needs a thorough look over. It's pretty complicated and the class needs a detailed explanation of the specific steps it takes to detect and report growth and provide a list of steps on how to use the class. It's interaction with the GlobalCharacter class and the character growth data/functions in Lua also need to be examined.

2) GlobalShard class still needs to be implemented. We don't have a clear understanding of what properties shards will have in the game though, so until we do we can't implement this class.

3) I think the GameGlobal class or perhaps a new GlobalMedia class should be used to retrieve common image data. For example, object category icons and elemental and status effect icons.

4) The GlobalStatusEffect class, as I mentioned, needs changes I think. Specifically, I think it should be downsized to a simple container class like GlobalElementalEffect is and all of the execution logic, etc should be moved to a new drived class in the battle code (BattleStatusEffect?). I'm not going to move forward on that though until we have some discussion about it.

There's not a lot of functional changes in all these commits, but all the global code is now more standard compliant, easier to read and understand, comments are updated to reflect the current game design, better error checking and reporting is now in place, and its altogether a nicer set of code to work with.
Image
User avatar
Roots
Dictator
Posts: 8669
Joined: Wed Jun 16, 2004 12:07 pm
Location: Austin TX
Contact:

Re: Subversion Commit Log

Post by Roots » Fri Feb 05, 2010 12:13 am

Committed revision #1699.
============================================================
Files Added
A src/common/global
A + src/common/global/global_objects.h
A + src/common/global/global_effects.cpp
A + src/common/global/global_actors.h
A + src/common/global/global.cpp
A + src/common/global/defs_global.cpp
A + src/common/global/global_skills.cpp
A + src/common/global/global_effects.h
A + src/common/global/global.h
A + src/common/global/global_skills.h
A + src/common/global/global_objects.cpp
A + src/common/global/global_actors.cpp

Files Removed
D src/global
D src/global/global_objects.h
D src/global/global_effects.cpp
D src/global/global.cpp
D src/global/global_actors.h
D src/global/defs_global.cpp
D src/global/global_skills.cpp
D src/global/global_effects.h
D src/global/global.h
D src/global/global_skills.h
D src/global/global_objects.cpp
D src/global/global_actors.cpp

Files Modified
M Makefile.am

Primary Changes
  • Moved global code from src/global/ to src/common/global. No naming changes or anything else was done.
Miscellaneous
OS X and Windows project files will need to be updated.
Image
User avatar
Roots
Dictator
Posts: 8669
Joined: Wed Jun 16, 2004 12:07 pm
Location: Austin TX
Contact:

Re: Subversion Commit Log

Post by Roots » Fri Feb 05, 2010 11:20 am

Committed revision #1700.
============================================================
Files Added
A snd/male_scream.ogg
A snd/menu_click_01.wav
A snd/menu_click_02.wav
A snd/wind.ogg
A snd/lively_crowd.ogg
A snd/missed_target.wav
A snd/fountain_small.ogg
A snd/female_scream.ogg
A snd/gentle_stream.ogg
A snd/makok_howl.ogg
A snd/fountain_large.ogg

Primary Changes
  • Added several sound files that Rain composed a while back
Image
User avatar
Roots
Dictator
Posts: 8669
Joined: Wed Jun 16, 2004 12:07 pm
Location: Austin TX
Contact:

Re: Subversion Commit Log

Post by Roots » Sat Feb 06, 2010 6:11 am

Committed revision #1702.
============================================================
Files Modified
M src/modes/battle/battle_actors.cpp
M src/modes/battle/battle_actions.cpp
M src/modes/battle/battle_actors.h
M img/menus/locations/blank.png
M img/menus/stamina_bar.png
M img/menus/battle_bottom_menu.png

Primary Changes
  • Removed the character portrait border from the bottom battle GUI area. It was an eyesore when there wasn't a character portrait drawn inside of it. I was going to draw the border only when a character is selected, but I think it actually looks better when the character's portrait is drawn and there's no border. I can add it back if you guys disagree.
  • Major upgrade to the stamina bar graphic. Now it has two areas with a command line indicator.
  • Updated the "blank" location graphic to have a location border and transparent black interior instead of being an invisible image. I did this so its clear where we're missing location graphics as opposed to not needing to draw the location graphic at all.
Miscellaneous
The actor stamina icons have issues with being drawn at the correct place. This is going to take a little work for me to fix because the code that does the icon drawing is rather sloppy.
Image
User avatar
Roots
Dictator
Posts: 8669
Joined: Wed Jun 16, 2004 12:07 pm
Location: Austin TX
Contact:

Re: Subversion Commit Log

Post by Roots » Sat Feb 06, 2010 8:15 am

Committed revision #1703.
============================================================
Files Modified
M src/utils.cpp
M src/defs.cpp
M src/engine/system.cpp
M src/engine/defs_engine.cpp
M src/engine/system.h
M src/utils.h
M dat/maps/betrayal_room.lua
M dat/maps/desert_training.lua
M dat/maps/demo_cave.lua
M dat/maps/desert_village.lua
M dat/maps/demo_town.lua
M dat/maps/opening_scene.lua
M dat/maps/desert_outskirts.lua
M dat/maps/desert_barracks.lua
M dat/config/languages.lua
M dat/actors/map_sprites_stock.lua

Primary Changes
  • Moved the Translate() function from utils.h to system.h
  • Wrote new function UTranslate() that returns a hoa_utils::ustring instead of a std::string
  • Updated all Lua files to use the moved Translate function call
Miscellaneous
Now instead of typing `hoa_utils.Translate("my string")` in Lua scripts, you should type `hoa_system.Translate("my string")`. The UTranslate function is just a short-hand for typing `MakeUnicodeString(Translate("my string"));`. This function does not (and probably will not) have bindings to Lua since Lua doesn't know what to do with ustrings.
Image
User avatar
Roots
Dictator
Posts: 8669
Joined: Wed Jun 16, 2004 12:07 pm
Location: Austin TX
Contact:

Re: Subversion Commit Log

Post by Roots » Sat Feb 06, 2010 2:38 pm

Committed revision #1704.
============================================================
Files Modified
M src/modes/boot/boot_welcome.cpp
M src/modes/boot/boot.cpp
M src/modes/menu/menu_views.cpp
M src/modes/menu/menu.cpp
M src/modes/menu/menu_views.h
M src/modes/shop/shop.cpp
M src/modes/shop/shop_root.cpp
M src/modes/shop/shop_leave.cpp
M src/modes/shop/shop_confirm.cpp
M src/modes/shop/shop_trade.cpp
M src/modes/shop/shop_sell.cpp
M src/modes/shop/shop_buy.cpp
M src/modes/battle/battle_windows.cpp
M src/modes/battle/battle_actors.cpp
M src/modes/map/map_treasure.cpp
M src/modes/pause.cpp
M src/modes/save/save_mode.cpp
M txt/allacrost.pot

Primary Changes
  • Translate calls added to all display text for all game mode C++ code
  • POT file updated accordingly
Miscellaneous
I hope this works. Didn't see any crashes happening anywhere but I'm a little anxious about moving into unknown territory.
Image
User avatar
Roots
Dictator
Posts: 8669
Joined: Wed Jun 16, 2004 12:07 pm
Location: Austin TX
Contact:

Re: Subversion Commit Log

Post by Roots » Sat Feb 06, 2010 4:21 pm

Committed revision #1705.
============================================================
Files Modified
M src/common/global/global.cpp

Primary Changes
  • Fixed a bug where game could crash anytime after entering a new game mode (besides map mode) after a characters has been removed from the party
Image
User avatar
Roots
Dictator
Posts: 8669
Joined: Wed Jun 16, 2004 12:07 pm
Location: Austin TX
Contact:

Re: Subversion Commit Log

Post by Roots » Sat Feb 06, 2010 6:45 pm

Committed revision #1706.
============================================================
Files Modified
M src/modes/menu/menu.cpp
M src/modes/menu/menu.h
M src/modes/shop/shop.cpp

Primary Changes
  • Removed the "Exit" action from menu mode
  • Removed the "Leave" action from shop mode
  • To leave the shop, you now just input a cancel command when the root menu is selected
Miscellaneous
This new dictator's powers of persuasion are not to be taken lightly. :bow:
Image
User avatar
Roots
Dictator
Posts: 8669
Joined: Wed Jun 16, 2004 12:07 pm
Location: Austin TX
Contact:

Re: Subversion Commit Log

Post by Roots » Sat Feb 06, 2010 7:41 pm

Committed revision #1708.
============================================================
Files Modified
M src/modes/battle/battle_actors.cpp
M img/menus/battle_character_selection.png

Primary Changes
  • The highlight image for the selected character wasn't covering the entire character line in the bottom battle menu. This commit fixes that issue.
Image
User avatar
gorzuate
Developer
Posts: 2575
Joined: Wed Jun 16, 2004 9:03 pm
Location: Hermosa Beach, CA
Contact:

Re: Subversion Commit Log

Post by gorzuate » Sat Feb 06, 2010 8:18 pm

Committed revisions #1710 & 1711.
============================================================
Files Modified
txt/POTFILES.in

Files Added
txt/LINGUAS

Primary Changes
  • Updated list of files containing translatable strings.
  • Added new file that contains a list of supported languages; this file is used in conjunction with the new command (to be posted to the wiki shortly) used to push new changes out to the translators.
Image
Locked