Hello, we apologize but forum registrations are non-functional at this time. This issue should be fixed around mid-December. Until then, please stop by our Discord channel if you'd like to get in touch with the team. Thanks!

Subversion Commit Log

For discussion of the code running behind the game

Moderator: Staff

Locked
User avatar
gorzuate
Developer
Posts: 2575
Joined: Wed Jun 16, 2004 9:03 pm
Location: Hermosa Beach, CA
Contact:

Re: Subversion Commit Log

Post by gorzuate » Mon Jan 25, 2010 1:59 pm

When did we decide to support mice? :huh:
Image
rujasu
Developer
Posts: 758
Joined: Sat Feb 24, 2007 10:40 pm
Location: Maryland, USA

Re: Subversion Commit Log

Post by rujasu » Mon Jan 25, 2010 2:05 pm

gorzuate wrote:When did we decide to support mice? :huh:
Personally, I don't have any desire for mouse support, but prophile wanted to add it in. As long as it doesn't cause maintenance headaches, it doesn't bother me (though an option to disable it would be nice.)
User avatar
prophile
Senior Member
Posts: 324
Joined: Fri Jan 27, 2006 12:18 pm
Location: Chaldon, Surrey, UK
Contact:

Re: Subversion Commit Log

Post by prophile » Mon Jan 25, 2010 2:52 pm

To disable mouse control, don't use your mouse. :)
Alastair Lynn / Resident Whinger / Allacrost
User avatar
Roots
Dictator
Posts: 8669
Joined: Wed Jun 16, 2004 12:07 pm
Location: Austin TX
Contact:

Re: Subversion Commit Log

Post by Roots » Mon Jan 25, 2010 5:33 pm

I think its better if this stuff goes into a branch since there's been no decision or even talk on the team about using it. In the past we've pretty much used our branches for "experimental" code. Its going to have to be disabled or removed (and not just by "not using your mouse") when it comes time to do an internal release. This will likely happen within a couple weeks, if not within a few days...
Image
User avatar
prophile
Senior Member
Posts: 324
Joined: Fri Jan 27, 2006 12:18 pm
Location: Chaldon, Surrey, UK
Contact:

Re: Subversion Commit Log

Post by prophile » Mon Jan 25, 2010 6:37 pm

Committed revision #1668.
============================================================
Revisions Reverted
  • 1667
  • 1666
  • 1665
  • 1664
  • 1663
  • 1661
Primary Changes
  • Reverted mouse control changes on trunk, for development in a separate branch.
Alastair Lynn / Resident Whinger / Allacrost
User avatar
Roots
Dictator
Posts: 8669
Joined: Wed Jun 16, 2004 12:07 pm
Location: Austin TX
Contact:

Re: Subversion Commit Log

Post by Roots » Tue Jan 26, 2010 1:44 pm

Committed revision #1669.
============================================================
Files Modified
M src/modes/shop/shop_utils.h
M src/modes/shop/shop.cpp
M src/modes/shop/shop.h
M src/modes/shop/shop_confirm.cpp
M src/modes/shop/shop_buy.cpp
M src/modes/shop/shop_utils.cpp
M src/modes/shop/shop_confirm.h
M src/modes/shop/shop_buy.h

Primary Changes
  • Shop mode's confirm interface is now partially implemented
Secondary Changes
  • Several changes to other shop code to provide/account for features of the confirm interface
Miscellaneous
I emphasize "partially" when I say partially implemented. You can't modify your order yet. You can clear your order, although the buy/sell interfaces aren't updating properly when you return to them after clearing your order due to an oversight on my part that will be corrected soon. It looks like you can complete your transaction, but this is not fully implemented yet either. It won't modify the party's drunes or inventory yet.

Overall this is coming along pretty nicely and the confirm interface is nearly complete. I think I'll have it finished for good (minus the trade transaction stuff) in the next commit or two, and the leave interface will follow soon after that.
Image
User avatar
Roots
Dictator
Posts: 8669
Joined: Wed Jun 16, 2004 12:07 pm
Location: Austin TX
Contact:

Re: Subversion Commit Log

Post by Roots » Wed Jan 27, 2010 5:37 pm

Committed revision #1670.
============================================================
Files Modified
M src/modes/shop/shop_utils.h
M src/modes/shop/shop_confirm.cpp
M src/modes/shop/shop_buy.cpp
M src/modes/shop/shop_sell.cpp
M src/modes/shop/shop_utils.cpp
M src/modes/shop/shop_buy.h
M src/modes/shop/shop_sell.h

Primary Changes
  • You can now modify your order within shop mode and view details about selected objects
Secondary Changes
  • Fixed a bug where if you decrease sell quantity it could glitch the financial data to allow the player to buy more than they had the funds for
  • Improved code re-use between buy/sell/confirm interfaces
Miscellaneous
You still can't complete financial transactions (it only clears the order). There's a bug in the sell interface where the listed sell quantities are not properly reset if you clear your order. Both issues should be resolved in my next commit.
Image
User avatar
Roots
Dictator
Posts: 8669
Joined: Wed Jun 16, 2004 12:07 pm
Location: Austin TX
Contact:

Re: Subversion Commit Log

Post by Roots » Thu Jan 28, 2010 11:22 am

Committed revision #1671.
============================================================
Files Modified
M src/modes/shop/shop_utils.h
M src/modes/shop/shop.cpp
M src/modes/shop/shop_root.h
M src/modes/shop/shop_confirm.cpp
M src/modes/shop/shop_sell.cpp
M src/modes/shop/shop_buy.cpp
M src/modes/shop/shop_utils.cpp
M src/modes/shop/shop_leave.h
M src/modes/shop/shop_confirm.h
M src/modes/shop/shop_sell.h
M src/modes/shop/shop_buy.h
M src/modes/shop/shop_trade.h

Primary Changes
  • The confirm interface is now fully functional. For the first time in weeks you can actually buy and sell stuff in shops. Fancy that :D
  • Fixed various issues with interfaces not updating/resetting themselves appropriately after leaving and re-entering the interface or after a transaction occurs
Miscellaneous
Next up is the leave interface, which will be quick because its basically a dumbed-down version of the now completed confirm interface. I'm also going to have the transaction interface print a message that says something like "This feature is not yet available." so players don't get to it, see a blank screen, and scratch their heads thinking its a bug. The trade interface I'll come back to at a later time.

Oh, and do me a favor guys and test the hell out of shop mode would ya? I tested it a lot but I wouldn't be surprised if there's a minor bug or two lurking around still.
Image
User avatar
Roots
Dictator
Posts: 8669
Joined: Wed Jun 16, 2004 12:07 pm
Location: Austin TX
Contact:

Re: Subversion Commit Log

Post by Roots » Thu Jan 28, 2010 2:40 pm

Committed revision #1672.
============================================================
Files Modified
M src/modes/shop/shop_leave.cpp
M src/modes/shop/shop_confirm.cpp
M src/modes/shop/shop_trade.cpp
M src/modes/shop/shop_leave.h
M src/modes/shop/shop_confirm.h
M src/modes/shop/shop_trade.h

Primary Changes
  • The leave interface is now fully functional
Secondary Changes
  • Trade interface now displays "This feature is not yet available."
  • Minor fixes to some comments in confirm interface
Miscellaneous
I'm done with shop mode for a while, except for fixing any bugs that you guys find and report. Its good to go for the internal release. I'm going to be digging around in other areas of the code in my next commits.
Image
User avatar
Shmoopy909
Newbie
Posts: 14
Joined: Mon Jun 01, 2009 9:31 am

Re: Subversion Commit Log

Post by Shmoopy909 » Sat Jan 30, 2010 12:46 pm

Committed revision #1673.
============================================================
Files Modified
M src/modes/boot/boot.cpp
M src/modes/boot/boot.h
M src/utils.cpp
M src/utils.h

Primary Changes

*Profiles are now in a separate directory from the saved games, the path is the user data path /profiles/
*Added a function to allow easy access to profile directory "GetUserProfilePath"


Secondary Changes

*Properly abstracted the file extensions on the profiles from the end user, i.e instead of seeing "profile.lua" under save/load/delete it is now "profile"
User avatar
Roots
Dictator
Posts: 8669
Joined: Wed Jun 16, 2004 12:07 pm
Location: Austin TX
Contact:

Re: Subversion Commit Log

Post by Roots » Sun Jan 31, 2010 2:39 am

Committed revision #1675.
============================================================
Files Modified
M src/modes/boot/boot_welcome.cpp
M src/modes/boot/boot_credits.cpp
M src/modes/boot/boot.cpp
M src/modes/boot/boot_welcome.h
M src/modes/boot/boot_credits.h
M src/modes/boot/boot_menu.cpp
M src/modes/boot/boot.h
M src/modes/boot/boot_menu.h
M src/modes/shop/shop.h
M src/defs.h

Primary Changes
  • Boot mode now uses the proper font sets and no longer relies on defunct fonts
  • Did *a lot* of clean-up to boot code, but still not enough! :eyespin:
Secondary Changes
  • Adjusted screen sizes for the boot welcome and credits windows. They look nicer now than they did before.
  • Arranged the order of function declarations and definitions in BootMode class so its easier to find what the heck you're looking for and to see related functions nearby
Known Bugs
The boot mode option menus don't fit inside the window. I think rather than spend time fixing these offsets, we should just make boot menus look nicer in the first play (see comments in misc. below).

Miscellaneous
I didn't really change any of the core logic of boot mode (that's about the only thing I left alone), but that doesn't mean there are no bugs. There may be some draw bugs or crashes/hangs. Boot mode is going to need a thorough testing before the release, but since there's still work to be done in this code so lets hold off on that.

Files which I consider fully polished and no longer in need of any touch-ups: boot_menu.*, boot_credits.*, boot_welcome.*. boot.h is mostly cleaned, but there were still some questionably named methods and members and some comments that I think need to be re-checked. boot.cpp by far needs the most work. A lot of the code in there is poorly structured, there's several violations of our code standard, plenty of useless comments that should be removed, etc.

I think its worthwhile to invest in making the boot mode options menu function as well and look as nice as the shop mode menus do. A lot of the options are not very intuitive, like being able to use left/right to adjust volume levels or toggle fullscreen mode. There's plenty of other work to do in boot mode as well, so I asked Shmoopy if he'd like to do it. If its not his thing, then this would be a good task for a new programmer because its not entirely complex and gives good exposure to a variety of engine interfaces.
Image
User avatar
Roots
Dictator
Posts: 8669
Joined: Wed Jun 16, 2004 12:07 pm
Location: Austin TX
Contact:

Re: Subversion Commit Log

Post by Roots » Sun Jan 31, 2010 1:21 pm

Committed revision #1675.
============================================================
Files Modified
M src/main.cpp
M src/modes/map/map.cpp
M src/modes/map/map_dialogue.cpp
M src/modes/map/map_treasure.cpp

Primary Changes
  • Map mode now uses the proper font sets and no longer relies on defunct fonts
Image
rujasu
Developer
Posts: 758
Joined: Sat Feb 24, 2007 10:40 pm
Location: Maryland, USA

Re: Subversion Commit Log

Post by rujasu » Sun Jan 31, 2010 7:57 pm

Committed revision #1677.
============================================================
Files Modified
M src/utils.cpp

Primary Changes
  • Fixed a bug where MakeUnicodeString was not properly setting memory to zero, resulting in malloc-related crashes. Thanks to prophile for pointing out how to fix this.
rujasu
Developer
Posts: 758
Joined: Sat Feb 24, 2007 10:40 pm
Location: Maryland, USA

Re: Subversion Commit Log

Post by rujasu » Sun Jan 31, 2010 9:55 pm

Committed revision #1678.
============================================================
Files Modified
M src/global/global.cpp
M dat/maps/betrayal_room.lua
M dat/maps/desert_training.lua
M dat/maps/opening_scene.lua
M dat/maps/desert_outskirts.lua

Primary Changes
  • Fixed a bug that came up with trying to load a game when another game was in progress. Inventory/events are always cleared now.
  • Adjusted map functions and ScriptedEvents to avoid having any functions of the same number between maps. For some reason, the namespaces aren't really working, so this avoids some bugs for us. Still, there is an underlying bug that needs to be fixed.
User avatar
Roots
Dictator
Posts: 8669
Joined: Wed Jun 16, 2004 12:07 pm
Location: Austin TX
Contact:

Re: Subversion Commit Log

Post by Roots » Sun Jan 31, 2010 11:41 pm

Committed revision #1679.
============================================================
Files Modified
M src/modes/battle/battle_windows.cpp
M src/modes/battle/battle_actors.cpp
M src/modes/battle/battle_windows.h
M src/modes/battle/battle_actors.h

Primary Changes
  • Battle mode character stats and action menu now use standard game fonts
Miscellaneous
The victory/defeat menu and damage text still remain to be updated. I'm not just changing fonts by the way, I'm also making all this code draw text as it should by not relying on costly VideoManager()->Text()->Draw("message") calls, which re-render their text and discard it every single frame. And of course I'm adjusting draw positions and orientations accordingly.
Image
User avatar
Roots
Dictator
Posts: 8669
Joined: Wed Jun 16, 2004 12:07 pm
Location: Austin TX
Contact:

Re: Subversion Commit Log

Post by Roots » Mon Feb 01, 2010 1:58 am

Committed revision #1680.
============================================================
Files Modified
M src/modes/pause.cpp
M src/modes/pause.h

Primary Changes
  • Updated pause mode to use the new standard font sets
Miscellaneous
Going to tackle menu mode next. I'm saving the last half of battle mode font/text updates for the end.
Image
User avatar
Roots
Dictator
Posts: 8669
Joined: Wed Jun 16, 2004 12:07 pm
Location: Austin TX
Contact:

Re: Subversion Commit Log

Post by Roots » Mon Feb 01, 2010 11:46 am

Committed revision #1681.
============================================================
Files Modified
M src/modes/boot/boot.cpp
M src/modes/menu/menu_views.cpp
M src/modes/menu/menu.cpp
M src/modes/menu/menu.h

Primary Changes
  • Updated menu mode to use the new standard font sets
Miscellaneous
I did tweak some draw offsets in this commit to get the text to be drawn in their respective window boundaries. I didn't replace all the inefficient Text()->Draw() calls this time because I think this entire interface deserves an overhaul and these calls were everywhere. When that time comes, we can replace those calls with TextImage objects appropriately. The fonts I chose are subject to change as well. For example many parts of header text in the sub menus (inventory, equipment, etc) should really be rendered with a title font, not the standard text font.
Image
User avatar
Roots
Dictator
Posts: 8669
Joined: Wed Jun 16, 2004 12:07 pm
Location: Austin TX
Contact:

Re: Subversion Commit Log

Post by Roots » Mon Feb 01, 2010 9:49 pm

Committed revision #1682.
============================================================
Files Modified
M src/engine/video/video.cpp
M src/engine/video/option.cpp
M src/engine/video/gui.cpp
M src/engine/video/text.h
M src/engine/video/texture_controller.cpp
M src/engine/video/text.cpp
M src/engine/video/context.h
M src/main.cpp
M src/modes/menu/menu_views.cpp
M src/modes/menu/menu.cpp
M src/modes/menu/menu_views.h
M src/modes/menu/menu.h
M src/modes/battle/battle_windows.cpp
M src/modes/battle/battle.cpp
M src/modes/save/save_mode.cpp

Primary Changes
  • Pause mode now uses new font sets
  • Menu mode now uses new font sets
  • Save mode now uses new font sets
  • Battle mode now uses only the new font sets
  • Old font sets are removed from the game entirely (the TTF font files remain in SVN for now, just in case)
  • Video engine was modified so it no longer uses the old default font/text colors and has font/text color saved in video contexts. The system is now entirely based on text styles
Secondary Changes
  • All text style constructors now use the appropriate properties of the default text style for the members that they are not given specific arguments for
  • Menu mode took a lot of tweaking to get working because of the odd way it had a static OptionBox member shared between classes
Miscellaneous
I wouldn't be surprised if there are warnings or crashes from this commit. Keep an eye out for new debug messages you haven't seen before or new crashes and let me know if you find something.

Menu mode is in very bad shape. This code needs a serious overhaul if not a complete re-write/re-design. I'd like for it to function and look as good as shop mode does now.
Image
User avatar
prophile
Senior Member
Posts: 324
Joined: Fri Jan 27, 2006 12:18 pm
Location: Chaldon, Surrey, UK
Contact:

Re: Subversion Commit Log

Post by prophile » Mon Feb 01, 2010 10:53 pm

Committed revision #1683.
============================================================
Files Modified
M src/global/global_effects.h
M src/engine/input.cpp
M src/engine/input.h
M src/engine/video/video.cpp
M src/engine/video/coord_sys.h
M src/engine/video/video.h
M src/main.cpp
M src/modes/boot/boot_welcome.cpp
M src/modes/boot/boot_credits.cpp
M src/modes/boot/boot.cpp
M src/modes/boot/boot_welcome.h
M src/modes/boot/boot_credits.h
M src/modes/boot/boot.h
M src/modes/boot/boot_menu.h
M src/modes/pause.h
M src/modes/menu/menu_views.cpp
M src/modes/menu/menu.cpp
M src/modes/menu/menu_views.h
M src/modes/menu/menu.h
M src/modes/shop/shop_utils.h
M src/modes/shop/shop.cpp
M src/modes/shop/shop_root.cpp
M src/modes/shop/shop.h
M src/modes/shop/shop_root.cpp
M src/modes/shop/shop.h
M src/modes/shop/shop_root.h
M src/modes/shop/shop_leave.cpp
M src/modes/shop/shop_confirm.cpp
M src/modes/shop/shop_sell.cpp
M src/modes/shop/shop_buy.cpp
M src/modes/shop/shop_utils.cpp
M src/modes/shop/shop_leave.h
M src/modes/shop/shop_confirm.h
M src/modes/shop/shop_sell.h
M src/modes/shop/shop_buy.h
M src/modes/battle/battle_windows.cpp
M src/modes/battle/battle_windows.h
M src/modes/map/map.h
M src/modes/map/map_dialogue.cpp
M src/modes/map/map_treasure.cpp
M src/modes/map/map_dialogue.h
M src/modes/map/map_treasure.h
M src/modes/save/save_mode.cpp
M src/modes/save/save_mode.h
M src/modes/pause.cpp
M src/defs.h
A src/common
A src/common/gui
A src/common/gui/menu_window.h
A src/common/gui/textbox.h
A src/common/gui/gui.cpp
A src/common/gui/option.cpp
A src/common/gui/gui.h
A src/common/gui/menu_window.cpp
A src/common/gui/option.h
A src/common/gui/textbox.cpp
M HoA.xcodeproj/project.pbxproj

Primary Changes
  • GUI is now in a separate library
Miscellaneous
This is pretty major. vcproj and autoconf files not updated - if somebody could do so I would be much obliged.
Alastair Lynn / Resident Whinger / Allacrost
User avatar
Roots
Dictator
Posts: 8669
Joined: Wed Jun 16, 2004 12:07 pm
Location: Austin TX
Contact:

Re: Subversion Commit Log

Post by Roots » Mon Feb 01, 2010 11:32 pm

Committed revision #1684.
============================================================
Files Removed
D src/engine/video/menu_window.h
D src/engine/video/option.cpp
D src/engine/video/gui.cpp
D src/engine/video/menu_window.cpp
D src/engine/video/textbox.h
D src/engine/video/option.h
D src/engine/video/gui.h
D src/engine/video/textbox.cpp

Files Modified
M Makefile.am

Primary Changes
  • Updated Linux makefile to work with new GUI code
  • Removed old GUI files that prophile forgot in his last commit
Miscellaneous
The editor won't compile on Linux yet because of a ToggleFPS() method still attached to the GUI code that needs to be moved to the video engine. The editor should not have a reason to include the GUI code so it will remain uncompilable until this fix is made. It should be a quick and easy one to do though.
Image
Locked