Hello, we apologize but forum registrations are non-functional at this time. This issue should be fixed around mid-December. Until then, please stop by our Discord channel if you'd like to get in touch with the team. Thanks!

Subversion Commit Log

For discussion of the code running behind the game

Moderator: Staff

Locked
User avatar
Roots
Dictator
Posts: 8669
Joined: Wed Jun 16, 2004 12:07 pm
Location: Austin TX
Contact:

Re: Subversion Commit Log

Post by Roots » Mon Jan 18, 2010 10:55 pm

Committed revision #1645.
============================================================
Files Modified
M src/main.cpp
M src/modes/shop/shop.cpp
M src/modes/shop/shop.h
M src/modes/shop/shop_buy.cpp

Primary Changes
  • The object viewer in shop mode now works properly for all types of objects in both view modes (summary and detail)
Image
User avatar
Roots
Dictator
Posts: 8669
Joined: Wed Jun 16, 2004 12:07 pm
Location: Austin TX
Contact:

Re: Subversion Commit Log

Post by Roots » Wed Jan 20, 2010 8:05 pm

Committed revision #1646.
============================================================
Files Modified
M src/engine/system.h
M src/modes/shop/shop_utils.h
M src/modes/shop/shop.cpp
M src/modes/shop/shop_root.cpp
M src/modes/shop/shop.h
M src/modes/shop/shop_sell.cpp
M src/modes/shop/shop_buy.cpp
M src/modes/shop/shop_utils.cpp
M src/modes/shop/shop_buy.h
M src/defs.h

Primary Changes
  • Buy interface animates category display switching
  • Simplified buy interface code
  • Improved code re-use
Secondary Changes
  • Added ability to force-finish system timers
  • Changed controls in buy interface. Now confirm toggles between list/detail view instead of menu key
Image
rujasu
Developer
Posts: 758
Joined: Sat Feb 24, 2007 10:40 pm
Location: Maryland, USA

Re: Subversion Commit Log

Post by rujasu » Wed Jan 20, 2010 9:12 pm

Committed revision #1647.
============================================================
Files Modified
M src/global/global.cpp
M src/modes/defs_modes.cpp
M src/modes/map/map_sprites.cpp
M dat/maps/betrayal_room.lua
M dat/maps/desert_training.lua
A img/sprites/map/kyle_attack_w.png

Primary Changes
  • Fixed a bug that was causing segfaults when you tried to save the game if Kyle had left the party. Basically, the RemoveCharacter function is supposed to remove the character from both the overall character list and the ordered list of characters in the active party. However, the ordered list points to the overall list, so you have to find the character in the ordered list before you delete it from the overall list, otherwise you can't check the ID in the ordered list since it's pointing to garbage.
  • Added animation before the betrayal battle to go with the dialogue.
User avatar
Roots
Dictator
Posts: 8669
Joined: Wed Jun 16, 2004 12:07 pm
Location: Austin TX
Contact:

Re: Subversion Commit Log

Post by Roots » Thu Jan 21, 2010 2:16 am

Committed revision #1649.
============================================================
Files Modified
M src/main.cpp
M src/modes/shop/shop_utils.h
M src/modes/shop/shop.cpp
M src/modes/shop/shop_root.cpp
M src/modes/shop/shop.h
M src/modes/shop/shop_sell.cpp
M src/modes/shop/shop_buy.cpp
M src/modes/shop/shop_utils.cpp
M src/modes/shop/shop_sell.h
M src/modes/shop/shop_buy.h

Primary Changes
  • Buy interface is now complete
  • Altered default font sets as was discussed in the forums earlier
Image
User avatar
Roots
Dictator
Posts: 8669
Joined: Wed Jun 16, 2004 12:07 pm
Location: Austin TX
Contact:

Re: Subversion Commit Log

Post by Roots » Thu Jan 21, 2010 4:10 am

Committed revision #1650.
============================================================
Files Modified
M src/modes/shop/shop_utils.h
M src/modes/shop/shop.cpp
M src/modes/shop/shop_root.cpp
M src/modes/shop/shop.h
M src/modes/shop/shop_sell.cpp
M src/modes/shop/shop_buy.cpp
M src/modes/shop/shop_utils.cpp
M src/modes/shop/shop_sell.h
M src/modes/shop/shop_buy.h

Primary Changes
  • Sell interface is now complete. Wasn't that fast? :D
Secondary Changes
  • Minor bug fixes and design changes done that I discovered when testing the sell interface
Miscellaneous
  • I didn't test the sell interface very thoroughly (only tested with 3 different types of potions in the inventory). I think it should be okay, but more testing with a fuller inventory is needed
  • Will now be going through fixing known bugs and warning messages in shop code before moving on to implementing the remaining three interfaces.
Image
User avatar
Roots
Dictator
Posts: 8669
Joined: Wed Jun 16, 2004 12:07 pm
Location: Austin TX
Contact:

Re: Subversion Commit Log

Post by Roots » Sat Jan 23, 2010 10:04 am

Committed revision #1652.
============================================================
Files Modified
M src/engine/audio/audio.cpp
M src/engine/video/textbox.cpp
M src/modes/shop/shop.cpp
M src/modes/shop/shop.h

Primary Changes
  • Fixed two warnings in shop mode. The first warned of text being too big for a textbox area (the offending textbox was for the object description text). The second warned about registered sounds still being active when the audio engine terminated (I wasn't 'delete'ing SoundDescriptor objects I had 'new'ed)
Secondary Changes
  • Improved some debug messages in audio engine and text box code
Miscellaneous
The only remaining warning shop mode is generating is something like this

Code: Select all

WARNING:src/engine/video/image_base.cpp:~BaseTexture:612: destructor invoked when the object had a reference count greater than zero: 30
This shouldn't be happening. Basically what this is saying is that after all images have been deleted, there are still references out there to the texture memory for those images. I thought that I took care of this case a long time ago and made it impossible for this to happen, but it looks like I was wrong. Either some images are being created with "new" and not being deleted, or something funky is going on with our memory referencing for image textures. I actually think this is a bug in the GUI code (OptionBox to be specific). I'm going to put off fixing this warning (even though its important) until a later time since its more likely than not that this is a problem outside of the shop code.

Next commit will be my first stab at the confirm interface.
Image
rujasu
Developer
Posts: 758
Joined: Sat Feb 24, 2007 10:40 pm
Location: Maryland, USA

Re: Subversion Commit Log

Post by rujasu » Sat Jan 23, 2010 11:21 pm

Committed revision #1653.
============================================================
Files Modified
M src/global/global.cpp
M dat/maps/betrayal_room.lua

Primary Changes
  • Cleaned up the betrayal room map, code is cleaner and sequence generally works well, except that there's a point where Claudius can move during a brief part of what should be a cutscene. I'm considering this low-priority though.
rujasu
Developer
Posts: 758
Joined: Sat Feb 24, 2007 10:40 pm
Location: Maryland, USA

Re: Subversion Commit Log

Post by rujasu » Sun Jan 24, 2010 5:38 pm

Committed revision #1654.
============================================================
Files Modified
M dat/maps/opening_scene.lua

Primary Changes
  • The opening map is supposed to look like a grassy hill... and now it actually does look like one.
User avatar
prophile
Senior Member
Posts: 324
Joined: Fri Jan 27, 2006 12:18 pm
Location: Chaldon, Surrey, UK
Contact:

Re: Subversion Commit Log

Post by prophile » Sun Jan 24, 2010 6:40 pm

Committed revision #1655.
============================================================
Files Modified
M src/*

Primary Changes
  • Updated the copyright date from 2004-2008 to 2004-2010.
Alastair Lynn / Resident Whinger / Allacrost
rujasu
Developer
Posts: 758
Joined: Sat Feb 24, 2007 10:40 pm
Location: Maryland, USA

Re: Subversion Commit Log

Post by rujasu » Sun Jan 24, 2010 7:26 pm

Committed revision #1656.
============================================================
Files Modified
M demo/dat/maps/betrayal_room.lua
M demo/dat/maps/desert_barracks.lua
M demo/dat/maps/desert_training.lua


Primary Changes
  • Modified the script sequence so that it's easier to follow for a player. In other words, there is more hand-holding and "where to go" hints. Some more adjustment will probably be in order, but it now looks more like a real game. Anyone who is able, please give this a test-drive and let me know how it plays for you.
rujasu
Developer
Posts: 758
Joined: Sat Feb 24, 2007 10:40 pm
Location: Maryland, USA

Re: Subversion Commit Log

Post by rujasu » Sun Jan 24, 2010 8:08 pm

Committed revision #1657.
============================================================
Files Modified
M src/modes/defs_modes.cpp
M src/modes/battle/battle.h
M src/modes/battle/battle.cpp
M src/modes/map/map_sprites.cpp
M src/modes/map/map_sprites.h
M dat/maps/new_cave.lua
M dat/maps/desert_outskirts.lua
M img/backdrops/battle/desert.png


Primary Changes
  • Added outdoor desert background.
  • Added code support for battle backgrounds to be defined in MapMode.
User avatar
prophile
Senior Member
Posts: 324
Joined: Fri Jan 27, 2006 12:18 pm
Location: Chaldon, Surrey, UK
Contact:

Re: Subversion Commit Log

Post by prophile » Sun Jan 24, 2010 8:12 pm

Committed revision #1657.
============================================================
Files Modified
M src/engine/audio/audio_descriptor.cpp


Primary Changes
  • Fixed a bug where sounds that couldn't be loaded would crash the game.
Alastair Lynn / Resident Whinger / Allacrost
rujasu
Developer
Posts: 758
Joined: Sat Feb 24, 2007 10:40 pm
Location: Maryland, USA

Re: Subversion Commit Log

Post by rujasu » Sun Jan 24, 2010 8:48 pm

Committed revision #1659.
============================================================
Files Modified
M src/modes/defs_modes.cpp
M src/modes/map/map_events.cpp
M src/modes/map/map_events.h
M dat/maps/desert_outskirts.lua

Primary Changes
  • Desert boss battle now uses the desert background. This took a bit more code support, since it uses BattleEncounterEvent to start a battle directly, instead of an EnemySprite.
rujasu
Developer
Posts: 758
Joined: Sat Feb 24, 2007 10:40 pm
Location: Maryland, USA

Re: Subversion Commit Log

Post by rujasu » Sun Jan 24, 2010 10:14 pm

Committed revision #1660.
============================================================
Files Modified
M dat/maps/desert_training.lua
M dat/actors/enemies_set_02.lua
M dat/tilesets/desert_ground.lua

Primary Changes
  • Slight modifications to the training hall map; the cave entrance to the west is a bit larger, so Claudius doesn't look like he's running into a wall when he goes that way. Still have to fix up the other two directions though.
  • Fixed the location of the "head" target for one of the boss enemies.
User avatar
prophile
Senior Member
Posts: 324
Joined: Fri Jan 27, 2006 12:18 pm
Location: Chaldon, Surrey, UK
Contact:

Re: Subversion Commit Log

Post by prophile » Sun Jan 24, 2010 10:38 pm

Committed revision #1661.
============================================================
Files Modified
M src/engine/input.h
M src/engine/input.cpp
M src/main.cpp

Primary Changes
  • Added support in the input manager for handling mice.
Alastair Lynn / Resident Whinger / Allacrost
rujasu
Developer
Posts: 758
Joined: Sat Feb 24, 2007 10:40 pm
Location: Maryland, USA

Re: Subversion Commit Log

Post by rujasu » Sun Jan 24, 2010 11:00 pm

Committed revision #1662.
============================================================
Files Modified
M dat/maps/desert_training.lua
M dat/maps/desert_barracks.lua
M dat/maps/desert_outskirts.lua

Primary Changes
  • Map boundaries extend the full length of the map edge in cases where that makes sense. This should make the boundaries work more naturally, since you generally won't run into an invisible wall if you're not on the path.
User avatar
prophile
Senior Member
Posts: 324
Joined: Fri Jan 27, 2006 12:18 pm
Location: Chaldon, Surrey, UK
Contact:

Re: Subversion Commit Log

Post by prophile » Sun Jan 24, 2010 11:07 pm

Committed revision #1663.
============================================================
Files Modified
M src/engine/input.cpp
M src/engine/input.h
M src/engine/video/coord_sys.h
M src/engine/video/gui.h
M src/engine/video/gui.cpp

Primary Changes
  • Added a method to check if the mouse has just been moved in input.h
  • Added methods to convert between normalised and local coordinates in coord_sys.h
  • Added a method to GUIElement to check if its bounding rectangle contains the mouse.
Alastair Lynn / Resident Whinger / Allacrost
User avatar
prophile
Senior Member
Posts: 324
Joined: Fri Jan 27, 2006 12:18 pm
Location: Chaldon, Surrey, UK
Contact:

Re: Subversion Commit Log

Post by prophile » Mon Jan 25, 2010 7:45 am

Committed revision #1664.
============================================================
Files Modified
M src/engine/input.cpp
M src/engine/video/option.cpp

Primary Changes
  • Fixed a bug in input where the y coordinate for the mouse was always wrong.
  • Made option boxes controllable with the mouse
Alastair Lynn / Resident Whinger / Allacrost
User avatar
prophile
Senior Member
Posts: 324
Joined: Fri Jan 27, 2006 12:18 pm
Location: Chaldon, Surrey, UK
Contact:

Re: Subversion Commit Log

Post by prophile » Mon Jan 25, 2010 8:19 am

Committed revision #1665.
============================================================
Files Modified
M src/modes/map/map.cpp

Primary Changes
  • Made map exploration controllable with the mouse
Alastair Lynn / Resident Whinger / Allacrost
User avatar
prophile
Senior Member
Posts: 324
Joined: Fri Jan 27, 2006 12:18 pm
Location: Chaldon, Surrey, UK
Contact:

Re: Subversion Commit Log

Post by prophile » Mon Jan 25, 2010 10:02 am

Committed revision #1667.
============================================================
Files Modified
M src/modes/map/map.cpp

Primary Changes
  • Made it possible to interact with nearby objects by clicking on them.
Alastair Lynn / Resident Whinger / Allacrost
Locked