Hello, we apologize but forum registrations are non-functional at this time. This issue should be fixed around mid-December. Until then, please stop by our Discord channel if you'd like to get in touch with the team. Thanks!

Subversion Commit Log

For discussion of the code running behind the game

Moderator: Staff

User avatar
Roots
Dictator
Posts: 8669
Joined: Wed Jun 16, 2004 12:07 pm
Location: Austin TX
Contact:

Re: Subversion Commit Log

Post by Roots » Sun Nov 02, 2008 12:54 pm

Committed reversion #1452.
============================================================
Files Added
A src/modes/map/map_utils.h
A src/modes/map/map_utils.cpp

Files Modified
M src/main_options.cpp
M src/engine/mode_manager.cpp
M src/engine/input.cpp
M src/engine/audio/audio.cpp
M src/engine/audio/audio_descriptor.h
M src/engine/audio/audio.h
M src/engine/script/script_modify.h
M src/engine/script/script_write.h
M src/engine/script/script.cpp
M src/engine/script/script_read.h
M src/engine/script/script.h
M src/engine/mode_manager.h
M src/engine/input.h
M src/engine/system.cpp
M src/engine/video/particle_manager.h
M src/engine/video/video.cpp
M src/engine/video/option.cpp
M src/engine/video/texture_controller.h
M src/engine/video/image_base.h
M src/engine/video/image.h
M src/engine/video/text.h
M src/engine/video/shake.cpp
M src/engine/video/particle_manager.cpp
M src/engine/video/video.h
M src/engine/video/effects.cpp
M src/engine/video/context.h
M src/engine/video/gui.h
M src/engine/defs_engine.cpp
M src/engine/system.h
M src/main.cpp
M src/editor/tileset_editor.cpp
M src/editor/grid.cpp
M src/editor/editor.cpp
M src/editor/editor_main.cpp
M src/utils.h
M src/modes/map/map_zones.h
M src/modes/map/map_events.cpp
M src/modes/map/map_events.h
M src/modes/map/map.cpp
M src/modes/map/map.h
M src/modes/map/map_tiles.h
M src/modes/map/map_objects.cpp
M src/modes/map/map_sprites.cpp
M src/modes/map/map_dialogue.h
M src/modes/map/map_objects.h
M src/modes/map/map_sprites.h
M src/modes/map/map_treasure.h
M src/defs.h
M Makefile.am

Primary Changes
  • Moved common map code to a new map_utils file to eliminate dependency headaches and help organize the map code better
  • Wrote three new classes: SpritePathMoveEvent, SpriteRandomMoveEvent, and SpriteAnimateEvent that serve as the equivalent of the corresponding Action* classes
Secondary Changes
  • Renamed all GameAudio, etc. engine singleton classes to AudioEngine, etc.
  • Rename MapMode::CalculateDrawInfo to MapMode::CalculateDrawFrame
Miscellaneous Notes
  • Project build files need to be updated (Linux ones are updated in this commit)
  • FYI: map mode zoom/perspective has been reverted. No particular reason for it, other than we don't need to mess around with it right now and its easier to work on the map draw bug in the same resolution we've always been accustomed to.
  • Events still haven't been tested. My next step is to add bindings for the new event classes, test the event system, and disable the sprite action system to see if map events can serve as a replacement to sprite actions. If so and if there are no dissenters to using map events in place of sprite actions, I'll remove all of the sprite action code and files.
  • I'll also soon be testing if events can replace dialogue actions, and if so will change that code as well
============================================================
Image
User avatar
Roots
Dictator
Posts: 8669
Joined: Wed Jun 16, 2004 12:07 pm
Location: Austin TX
Contact:

Re: Subversion Commit Log

Post by Roots » Fri Nov 07, 2008 7:24 am

Committed reversion #1453.
============================================================
Files Removed
D src/modes/map/map_actions.h
D src/modes/map/map_actions.cpp

Files Modified
M src/modes/defs_modes.cpp
M src/modes/map/map_events.cpp
M src/modes/map/map_events.h
M src/modes/map/map_tiles.cpp
M src/modes/map/map.cpp
M src/modes/map/map_tiles.h
M src/modes/map/map.h
M src/modes/map/map_sprites.cpp
M src/modes/map/map_objects.cpp
M src/modes/map/map_dialogue.cpp
M src/modes/map/map_objects.h
M src/modes/map/map_dialogue.h
M src/modes/map/map_sprites.h
M src/modes/map/map_zones.cpp
M src/defs.h
M dat/maps/demo_cave.lua
M dat/maps/demo_town.lua
M Makefile.am

Primary Changes
  • Sprite actions have been removed. In their place the event system is used
  • Dialogue actions too have been removed and are replaced by dialogue events
  • A special type of abstract event "SpriteEvent" has been created for those events which directly control a sprite
  • Changes to sprite management code to work with new event system
  • Updated both map files
Secondary Changes
  • Renamed all map manager classes to supervisors (TileManager => TileSupervisor)
Known Bugs
  • If you try to enter the cave map, an error occurs and the game quits. I'll commit a fix when I can
Miscellaneous Notes
  • Large commit (3,192 lines changed)
  • The town map should work the same as it has before
  • Tested: sprite events, dialogue events, PathMoveSpriteEvent, RandomMoveSpriteEvent, AnimateSpriteEvent, ScriptedEvent, pausing/resuming events
  • Project build files need to be updated (Linux ones are updated in this commit)
  • With this commit, I now consider the map mode event management task to be completed :approve:
  • Next steps: test DialogueEvent, add more common event classes like going into shop mode, transitioning to a new map, playing a sound
============================================================
Image
User avatar
gorzuate
Developer
Posts: 2575
Joined: Wed Jun 16, 2004 9:03 pm
Location: Hermosa Beach, CA
Contact:

Re: Subversion Commit Log

Post by gorzuate » Sun Nov 09, 2008 5:52 pm

Committed reversion #1454 & 1455.
============================================================
Files Modified
M txt/allacrost.pot
M dat/maps/demo_cave.lua
M dat/maps/demo_town.lua

Primary Changes
  • Updated allacrost.pot to take into account changes to the map files.
  • The xgettext utility, which creates allacrost.pot (which is the main file that lists all of the strings needing translation), gets confused when an apostrophe or a single double quote (i.e. not followed by an ending double quote or ending apostrophe) is used in a comment in the lua files. This causes the line numbers in allacrost.pot that reference the location in the map file of the string needing translation to get messed up and become incorrect. I just updated the map files so that wherever there was an apostrophe there are now two (i.e. like so '').
============================================================
Image
User avatar
Wiinis
Newbie
Posts: 15
Joined: Tue Oct 21, 2008 10:34 pm
Location: Hawaii

Re: Subversion Commit Log

Post by Wiinis » Mon Nov 10, 2008 2:27 pm

Committed reversion #1456
============================================================
Files Modified
M map_events.cpp

Primary Changes
  • fixed a bug where the list of events could go out of bounds in EventSupervisor::Update()
Linds
Developer
Posts: 145
Joined: Tue Jan 09, 2007 2:21 am
Location: Sydney, Australia

Re: Subversion Commit Log

Post by Linds » Wed Nov 12, 2008 5:12 am

Committed reversion #1457
============================================================
Files Modified
M src/engine/video/textbox.cpp
M src/engine/video/textbox.h
M src/engine/video/video.cpp
M src/engine/video/video.h

Primary Changes
  • Added ability to enable outline drawing on all TextBoxes
Secondary Changes
  • Added helper functions VideoEngine::DrawLine and VideoEngine::DrawRect
Miscellaneous Notes
  • Use the TextBox::DEBUG_EnableDrawOutline(bool) method to control this behaviour
Linds
Developer
Posts: 145
Joined: Tue Jan 09, 2007 2:21 am
Location: Sydney, Australia

Re: Subversion Commit Log

Post by Linds » Wed Nov 12, 2008 5:13 am

Committed reversion #1458
============================================================
Files Modified
M src/engine/video/textbox.cpp

Primary Changes
  • Fix typos from previous commit.
User avatar
Roots
Dictator
Posts: 8669
Joined: Wed Jun 16, 2004 12:07 pm
Location: Austin TX
Contact:

Re: Subversion Commit Log

Post by Roots » Wed Nov 12, 2008 9:22 am

Thanks Linds. That feature is going to be really, really useful for us to properly align and position all of our menus throughout the game, which is one of the items to do for the next release. :approve:
Image
User avatar
Roots
Dictator
Posts: 8669
Joined: Wed Jun 16, 2004 12:07 pm
Location: Austin TX
Contact:

Re: Subversion Commit Log

Post by Roots » Sat Nov 15, 2008 5:21 pm

Committed reversion #1459.
============================================================
Files Modified
M src/engine/video/menu_window.h
M src/engine/video/video.cpp
M src/engine/video/option.cpp
M src/engine/video/gui.cpp
M src/engine/video/menu_window.cpp
M src/engine/video/textbox.h
M src/engine/video/video.h
M src/engine/video/option.h
M src/engine/video/gui.h
M src/engine/video/textbox.cpp
M src/modes/map/map_events.cpp
M src/modes/map/map_utils.h
M src/modes/map/map_events.h
M src/modes/map/map.h
M src/defs.h

Primary Changes
  • Added some new map event classes (still need to be completed and tested)
  • Taking steps to enable outline drawing on all GUI elements, not just text boxes
  • Debug GUI outline drawing is now done on a global basis instead of a per-textbox basis
  • Outlines are now enabled in this commit (until we fix all positioning issues) and the outline display has been improved (white line represents the absolute outline)
Known Bugs
  • Debug outline drawing does not work for MenuWindows (unexpected)
  • Debug outline drawing does not work for OptionBoxes (expected)
Miscellaneous Notes
  • I made the _width, _height members of MenuWindow and TextBox a part of the GUIElement base class instead. OptionBox does not use a width/height, but it should.
  • This commit made me realize that OptionBox needs *a lot* of work. Substantial changes need to be made to this class prior to our next release
============================================================
Image
User avatar
gorzuate
Developer
Posts: 2575
Joined: Wed Jun 16, 2004 9:03 pm
Location: Hermosa Beach, CA
Contact:

Re: Subversion Commit Log

Post by gorzuate » Sun Nov 16, 2008 12:31 am

Committed reversion #1461
============================================================
Files Added
A txt/fr.po

Files Modified
M src/engine/system.cpp

Primary Changes
  • Gettext support should now be fully functional.
  • Added beginnings of french translation file.
Notes
  • Windows devs: tweaks may be needed to get the location of the translated files correct. :shrug:
  • OS X devs: you must download and install the new libs here before you can successfully compile.
  • I will write up instructions on the wiki on gettext and how to use it shortly (hopefully, by tomorrow).
Image
User avatar
gorzuate
Developer
Posts: 2575
Joined: Wed Jun 16, 2004 9:03 pm
Location: Hermosa Beach, CA
Contact:

Re: Subversion Commit Log

Post by gorzuate » Mon Nov 17, 2008 11:53 pm

Committed reversion #1462
============================================================
Files Modified
M configure.ac
M Makefile.am

Primary Changes
  • Defines PACKAGE and LOCALEDIR
Image
User avatar
gorzuate
Developer
Posts: 2575
Joined: Wed Jun 16, 2004 9:03 pm
Location: Hermosa Beach, CA
Contact:

Re: Subversion Commit Log

Post by gorzuate » Mon Nov 17, 2008 11:57 pm

Committed reversion #1464
============================================================
Files Modified
M src/modes/boot/boot.h
M src/modes/boot/boot.cpp

Primary Changes
  • Added some menu code to select different languages from the boot menu.
Notes
Still needs the following:
  • A function, probably in the TextSupervisor class, that can be called from boot mode when the user selects a different language that will clear out all text that has already been cached in the old language. After that we would also need to reload text in the new language.
  • A way to dynamically generate a list of languages to choose from by going through the languages that are currently available for use.
Image
User avatar
Roots
Dictator
Posts: 8669
Joined: Wed Jun 16, 2004 12:07 pm
Location: Austin TX
Contact:

Re: Subversion Commit Log

Post by Roots » Tue Nov 18, 2008 3:38 am

Committed reversion #1465.
============================================================
Files Modified
M src/engine/video/menu_window.h
M src/engine/video/option.cpp
M src/engine/video/gui.cpp
M src/engine/video/menu_window.cpp
M src/engine/video/textbox.h
M src/engine/video/textbox.cpp

Primary Changes
  • Fixed debug outlines not being displayed properly on menu windows or text boxes
  • Fixed problem made in previous commit where options were not correctly aligned to their menu windows
Known Bugs
  • Debug outline drawing does not work for map mode dialogue winodws, because they don't call MenuWindow::Draw like they should (that's been a todo in that part of the code for a while)
  • Debug outline drawing still does not work for OptionBoxes (expected)
============================================================
Image
User avatar
Roots
Dictator
Posts: 8669
Joined: Wed Jun 16, 2004 12:07 pm
Location: Austin TX
Contact:

Re: Subversion Commit Log

Post by Roots » Wed Nov 19, 2008 8:27 pm

Committed reversion #1466.
============================================================
Files Modified
M src/engine/video/option.cpp
M src/engine/video/textbox.h
M src/engine/video/option.h
M src/engine/video/gui.h
M src/engine/video/textbox.cpp
M src/modes/boot/boot_menu.cpp
M src/modes/menu/menu_views.cpp
M src/modes/menu/menu.cpp
M src/modes/shop/shop_windows.cpp
M src/modes/battle/battle_windows.cpp
M src/modes/map/map_dialogue.cpp
M src/modes/map/map_treasure.cpp
M src/modes/map/map_dialogue.h
M src/modes/pause.cpp

Primary Changes
  • Option boxes now use text styles to render option text
  • Dialogue windows in map mode have been modified for better text alignment

Secondary Changes
  • Some cleanup with the text box class
Known Bugs
  • Option text is drawn over dialogue text in dialogues. This is because the map dialogues need to be constructed in a manner which does not allow text and option lists to appear together
Miscellaneous Notes
  • The main purpose of this commit is to make progress towards perfecting the appearance of dialogues in map mode (a release checklist item)
  • I removed the nameplate image from dialogues. The name text now just sits directly underneath the character portrait. We'll see what people's reaction is
  • I'll be asking for feedback on dialogue appearance in another thread.
============================================================
Image
User avatar
Roots
Dictator
Posts: 8669
Joined: Wed Jun 16, 2004 12:07 pm
Location: Austin TX
Contact:

Re: Subversion Commit Log

Post by Roots » Wed Nov 26, 2008 2:03 pm

Committed reversion #1467.
============================================================
Files Modified
M src/engine/video/option.cpp
M src/engine/video/text.h
M src/engine/video/option.h
M src/engine/video/text.cpp
M src/engine/video/textbox.cpp
M src/main.cpp
M src/modes/boot/boot.cpp
M src/modes/boot/boot_menu.cpp
M src/modes/boot/boot.h
M src/modes/boot/boot_menu.h
M src/modes/menu/menu_views.cpp
M src/modes/menu/menu.cpp
M src/modes/shop/shop_windows.cpp
M src/modes/battle/battle_windows.cpp
M src/modes/map/map_dialogue.cpp
M src/modes/map/map_treasure.cpp
M src/modes/pause.cpp

Primary Changes
  • Modified API of OptionBox objects so we can support more options than can fit in a screen
  • Enabled outline debugging for option boxes

Secondary Changes
  • Had to modify a lot of other code to accommodate these changes
Known Bugs
  • Every mode that uses option boxes is likely to have bugs as a result of this change.
  • Boot mode is in a state of disrepair. Options menus will not work, but everything else on the main menu appears to be okay
Miscellaneous Notes
  • No, I don't like that I had to break so many things in this commit. It would take me forever to fix them all myself though so I just fixed the critical ones in boot mode for now
  • Future plans for option box code: improve internal code flow, comments, and organization. Add support for accessing option box image objects. Add support for scrolling through option boxes
  • Future plans for bug fixing: I'll be doing map mode first and then pause mode. I'm leaving everything else alone for now since we're not doing any work in these other modes
============================================================
Image
User avatar
Roots
Dictator
Posts: 8669
Joined: Wed Jun 16, 2004 12:07 pm
Location: Austin TX
Contact:

Re: Subversion Commit Log

Post by Roots » Thu Nov 27, 2008 11:53 pm

Committed reversion #1470.
============================================================
Files Modified
M src/engine/video/option.cpp
M src/engine/video/option.h

Primary Changes
  • Added support for accessing the StillImage object embedded inside each OptionBox option
Miscellaneous Notes
  • I'm going to discuss this commit and other option box changes in the team programming forum, so refer to that
  • FYI, previous two commits I fixed pause mode and map mode option boxes, and changed the treasure menu a bit
============================================================
Image
User avatar
Roots
Dictator
Posts: 8669
Joined: Wed Jun 16, 2004 12:07 pm
Location: Austin TX
Contact:

Re: Subversion Commit Log

Post by Roots » Sat Nov 29, 2008 2:58 pm

Committed reversion #1471.
============================================================
Files Modified
M src/engine/video/option.cpp
M src/engine/video/option.h

Primary Changes
  • Option box draw code cleaned up. No longer a big, monolithic and unorganized function
  • For option boxes with switching enabled (ability to switch the positions of two options), the first selected cursor should now be drawn in 50% alpha black (not verified if this works though)
Known Issues
  • There are a lot of warnings about comparison between signed and unsigned integer expressions. I'm in the process of cleaning this up (many members of OptionBox have been int32 when they should have been uint32)
============================================================
Image
User avatar
Wiinis
Newbie
Posts: 15
Joined: Tue Oct 21, 2008 10:34 pm
Location: Hawaii

Re: Subversion Commit Log

Post by Wiinis » Wed Dec 03, 2008 2:57 am

Committed reversion #1472.
============================================================

Files Modified
M src\modes\map\map_events.cpp
M src\modes\map\map_events.h
M src\modes\map\map_objects.cpp
M src\modes\map\map_objects.h
M src\modes\map\map_sprites.cpp
M src\modes\map\map_sprites.h

Primary Changes
  • Changed the way the characters/npc gets "rolled off" to the side in order to pass objects.
  • Added IsPositionOccupied() in map_objects.cpp for collision detection to help in path finding.
  • Moved destination, current_node, path from map_events to map_sprites
  • Now randomly moved NPCs (child, etc) will change to another random direction as soon as it collide with something.
  • Predetermined path NPCs (Marcus, etc) will change their destination to the next one in line.

Known Issues
  • For example, if a NPC has destination A -> B -> C -> A..., and it got blocked half way from A -> B at position D, the loop will now become A -> D -> C -> A....
============================================================
User avatar
prophile
Senior Member
Posts: 324
Joined: Fri Jan 27, 2006 12:18 pm
Location: Chaldon, Surrey, UK
Contact:

Re: Subversion Commit Log

Post by prophile » Wed Dec 03, 2008 5:04 pm

It's "revision," not "reversion," damn it! :bash:
Alastair Lynn / Resident Whinger / Allacrost
User avatar
Wiinis
Newbie
Posts: 15
Joined: Tue Oct 21, 2008 10:34 pm
Location: Hawaii

Re: Subversion Commit Log

Post by Wiinis » Wed Dec 03, 2008 6:17 pm

I blame roots since I copy/pasted for the layout ><
Winter Knight
Contributor
Posts: 304
Joined: Fri Sep 21, 2007 6:35 am
Contact:

Re: Subversion Commit Log

Post by Winter Knight » Fri Dec 05, 2008 6:26 am

Wow. We've been doing that since the start of this thread in September. I did it too. Didn't even notice. I also copied from Roots.
Locked